[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PATCH v3 7/7] hw/scsi/spapr_vscsi: Convert debug fprintf() to trace eve
From: |
Philippe Mathieu-Daudé |
Subject: |
[PATCH v3 7/7] hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event |
Date: |
Thu, 5 Mar 2020 13:12:53 +0100 |
Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
---
hw/scsi/spapr_vscsi.c | 4 +---
hw/scsi/trace-events | 1 +
2 files changed, 2 insertions(+), 3 deletions(-)
diff --git a/hw/scsi/spapr_vscsi.c b/hw/scsi/spapr_vscsi.c
index c4c4f31170..923488beb2 100644
--- a/hw/scsi/spapr_vscsi.c
+++ b/hw/scsi/spapr_vscsi.c
@@ -839,9 +839,7 @@ static int vscsi_process_tsk_mgmt(VSCSIState *s, vscsi_req
*req)
uint64_t tag = iu->srp.rsp.tag;
uint8_t sol_not = iu->srp.cmd.sol_not;
- fprintf(stderr, "vscsi_process_tsk_mgmt %02x\n",
- iu->srp.tsk_mgmt.tsk_mgmt_func);
-
+ trace_spapr_vscsi_process_tsk_mgmt(iu->srp.tsk_mgmt.tsk_mgmt_func);
d = vscsi_device_find(&s->bus,
be64_to_cpu(req_iu(req)->srp.tsk_mgmt.lun), &lun);
if (!d) {
diff --git a/hw/scsi/trace-events b/hw/scsi/trace-events
index b0820052f8..9a4a60ca63 100644
--- a/hw/scsi/trace-events
+++ b/hw/scsi/trace-events
@@ -227,6 +227,7 @@ spapr_vscsi_command_complete_status(uint32_t status)
"Command complete err=%"PRI
spapr_vscsi_save_request(uint32_t qtag, unsigned desc, unsigned offset)
"saving tag=%"PRIu32", current desc#%u, offset=0x%x"
spapr_vscsi_load_request(uint32_t qtag, unsigned desc, unsigned offset)
"restoring tag=%"PRIu32", current desc#%u, offset=0x%x"
spapr_vscsi_process_login(void) "Got login, sending response !"
+spapr_vscsi_process_tsk_mgmt(uint8_t func) "tsk_mgmt_func 0x%02x"
spapr_vscsi_queue_cmd_no_drive(uint64_t lun) "Command for lun 0x%08" PRIx64 "
with no drive"
spapr_vscsi_queue_cmd(uint32_t qtag, unsigned cdb, const char *cmd, int lun,
int ret) "Queued command tag 0x%"PRIx32" CMD 0x%x=%s LUN %d ret: %d"
spapr_vscsi_do_crq(unsigned c0, unsigned c1) "crq: %02x %02x ..."
--
2.21.1
- [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 1/7] hw/scsi/viosrp: Add missing 'hw/scsi/srp.h' include, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 2/7] hw/scsi/spapr_vscsi: Use SRP_MAX_IU_LEN instead of sizeof flexible array, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 3/7] hw/scsi/spapr_vscsi: Simplify a bit, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 4/7] hw/scsi/spapr_vscsi: Introduce req_iu() helper, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 5/7] hw/scsi/spapr_vscsi: Do not mix SRP IU size with DMA buffer size, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 6/7] hw/scsi/spapr_vscsi: Prevent buffer overflow, Philippe Mathieu-Daudé, 2020/03/05
- [PATCH v3 7/7] hw/scsi/spapr_vscsi: Convert debug fprintf() to trace event,
Philippe Mathieu-Daudé <=
- Re: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow, no-reply, 2020/03/05
- Re: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow, no-reply, 2020/03/05
- Re: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow, Paolo Bonzini, 2020/03/05
- Re: [PATCH v3 0/7] hw/scsi/spapr_vscsi: Fix time bomb buffer overflow, David Gibson, 2020/03/05