[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 1/7] target/ppc: Enforce that the root page directory size mu
From: |
Greg Kurz |
Subject: |
Re: [PATCH 1/7] target/ppc: Enforce that the root page directory size must be at least 5 |
Date: |
Mon, 30 Mar 2020 12:45:33 +0200 |
On Mon, 30 Mar 2020 11:49:40 +0200
Cédric Le Goater <address@hidden> wrote:
> From: Suraj Jitindar Singh <address@hidden>
>
> According to the ISA the root page directory size of a radix tree for
> either process- or partition-scoped translation must be >= 5.
>
> Thus add this to the list of conditions checked when validating the
> partition table entry in validate_pate();
>
> Signed-off-by: Suraj Jitindar Singh <address@hidden>
> Reviewed-by: David Gibson <address@hidden>
> Signed-off-by: Cédric Le Goater <address@hidden>
> ---
Reviewed-by: Greg Kurz <address@hidden>
> target/ppc/mmu-radix64.c | 3 +++
> 1 file changed, 3 insertions(+)
>
> diff --git a/target/ppc/mmu-radix64.c b/target/ppc/mmu-radix64.c
> index 224e646c5094..99678570581b 100644
> --- a/target/ppc/mmu-radix64.c
> +++ b/target/ppc/mmu-radix64.c
> @@ -212,6 +212,9 @@ static bool validate_pate(PowerPCCPU *cpu, uint64_t lpid,
> ppc_v3_pate_t *pate)
> if (lpid == 0 && !msr_hv) {
> return false;
> }
> + if ((pate->dw0 & PATE1_R_PRTS) < 5) {
> + return false;
> + }
> /* More checks ... */
> return true;
> }