[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0 3/8] tests/acceptance/ppc_prep_40p: Use mirror for ft

From: Wainer dos Santos Moschetta
Subject: Re: [PATCH-for-5.0 3/8] tests/acceptance/ppc_prep_40p: Use mirror for ftp.software.ibm.com
Date: Mon, 6 Apr 2020 10:54:55 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.4.0

On 4/3/20 2:29 PM, Philippe Mathieu-Daudé wrote:
To avoid regular failures on Travis-CI with ftp.software.ibm.com,
use a mirror.

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
  tests/acceptance/ppc_prep_40p.py | 3 ++-
  1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/tests/acceptance/ppc_prep_40p.py b/tests/acceptance/ppc_prep_40p.py
index 138064285a..1515561249 100644
--- a/tests/acceptance/ppc_prep_40p.py
+++ b/tests/acceptance/ppc_prep_40p.py
@@ -30,7 +30,8 @@ def test_factory_firmware_and_netbsd(self):
          :avocado: tags=machine:40p
          :avocado: tags=slowness:high
-        bios_url = ('ftp://ftp.boulder.ibm.com/rs6000/firmware/'
+        bios_url = ('http://ftpmirror.your.org/pub/misc/'
+                    'ftp.software.ibm.com/rs6000/firmware/'

I checked the bios file can be downloaded from the mirror. I cannot judge the mirror is more reliable than ftp.boulder.ibm.com or not, though.

Code-wise, looks good. So:

Reviewed-by: Wainer dos Santos Moschetta <address@hidden>

          bios_hash = '1775face4e6dc27f3a6ed955ef6eb331bf817f03'
          bios_path = self.fetch_asset(bios_url, asset_hash=bios_hash)

reply via email to

[Prev in Thread] Current Thread [Next in Thread]