[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.1 7/8] .travis.yml: Run fetch-acceptance-assets before

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH-for-5.1 7/8] .travis.yml: Run fetch-acceptance-assets before check-acceptance
Date: Mon, 6 Apr 2020 17:39:01 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/6/20 5:31 PM, Alex Bennée wrote:

Philippe Mathieu-Daudé <address@hidden> writes:

Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
  .travis.yml | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/.travis.yml b/.travis.yml
index 2fd63eceaa..c6b32da447 100644
--- a/.travis.yml
+++ b/.travis.yml
@@ -317,7 +317,7 @@ jobs:
        dist: bionic
          - CONFIG="--enable-tools 
-        - TEST_CMD="make check-acceptance"
+        - TEST_CMD="travis_retry make -j1 fetch-acceptance-assets
check-acceptance DEBUG=1"

You could use TEST_BUILD_CMD for the fetching of acceptance tests - can
that be done in parallel?

I'd say calling fetch-acceptance-assets parallelized is what seems to break this Travis job (which is why I enforced -j1), but I'll refer to Willian here.

Also no point in -j1 here - it's implied.

You are right, I wanted to be sure this still work even if the globlal script running the tests is updated. But the correct fix is probably to use .NOTPARALLEL in the fetch-acceptance-assets rule in the previous patch.

          - CACHE_NAME="${TRAVIS_BRANCH}-linux-gcc-acceptance"
          - python3 -c 'import json; r = json.load(open("tests/results/latest/results.json")); [print(t["logfile"]) for 
t in r["tests"] if t["status"] not in ("PASS", "SKIP")]' | xargs cat

reply via email to

[Prev in Thread] Current Thread [Next in Thread]