[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH-for-5.0 v2 2/2] gdbstub: Introduce gdb_get_float64() to get 6

From: Richard Henderson
Subject: Re: [PATCH-for-5.0 v2 2/2] gdbstub: Introduce gdb_get_float64() to get 64-bit float registers
Date: Tue, 14 Apr 2020 14:10:14 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.4.1

On 4/14/20 7:32 AM, Philippe Mathieu-Daudé wrote:
> When converted to use GByteArray in commits 462474d760c and
> a010bdbe719, the call to stfq_p() was removed. This call
> serialize a float.
> Since we now use a GByteArray, we can not use stfq_p() directly.
> Introduce the gdb_get_float64() helper to load a float64 register.
> Fixes: 462474d760c ("target/m68k: use gdb_get_reg helpers")
> Fixes: a010bdbe719 ("extend GByteArray to read register helpers")
> Signed-off-by: Philippe Mathieu-Daudé <address@hidden>
> ---
>  include/exec/gdbstub.h          | 12 ++++++++++++
>  target/m68k/helper.c            |  3 ++-
>  target/ppc/gdbstub.c            |  4 ++--
>  target/ppc/translate_init.inc.c |  2 +-
>  4 files changed, 17 insertions(+), 4 deletions(-)

This one can wait for 5.1, or be dropped altogether, depending.

In this case, we're only making the artificial distinction between float64 and
uint64_t.  Therefore all of the existing uses of gdb_get_reg64 that you replace
are not bug fixes.  Therefore, not 5.0 material.

I've been considering removing float32 and float64, and just replacing them
with uint32_t and uint64_t, and removing all of the associated shims like
stfq_p.  But I've never quite gotten around to doing that.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]