[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 2/4] smbus: Fix spd_data_generate() error API violation
Date: Fri, 24 Apr 2020 12:18:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.5.0

On 4/24/20 11:45 AM, Markus Armbruster wrote:
BALATON Zoltan <address@hidden> writes:
On Tue, 21 Apr 2020, Markus Armbruster wrote:

Here's what I actually disagree with:

1. QEMU warning the user about its choice of memory type, but only
sometimes.  Why warn?  There is nothing wrong, and there is nothing the
user can do to avoid the condition that triggers the warning.

The memory size that triggers the warning is specified by the user so
the user can do someting about it.

There is no way to trigger the warning.  If we dropped PATCH 1 instead
of fixing it as I did in v2, then the only way to trigger the warning is
-M sam460ex -m 64 or -m 32, and the only way to avoid it is to don't do

Why would a user care whether he gets DDR or DDR2 memory?

To use a different firmware code path!

reply via email to

[Prev in Thread] Current Thread [Next in Thread]