[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 4/5] mac_oldworld: Rename ppc_heathrow_reset reset to ppc_
From: |
Mark Cave-Ayland |
Subject: |
Re: [PATCH v2 4/5] mac_oldworld: Rename ppc_heathrow_reset reset to ppc_heathrow_cpu_reset |
Date: |
Sun, 14 Jun 2020 11:54:15 +0100 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.9.0 |
On 13/06/2020 14:36, BALATON Zoltan wrote:
> This function resets a CPU not the whole machine so reflect that in
> its name.
>
> Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
> ---
> hw/ppc/mac_oldworld.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/mac_oldworld.c b/hw/ppc/mac_oldworld.c
> index 4dd872c1a3..9138752ccb 100644
> --- a/hw/ppc/mac_oldworld.c
> +++ b/hw/ppc/mac_oldworld.c
> @@ -73,7 +73,7 @@ static uint64_t translate_kernel_address(void *opaque,
> uint64_t addr)
> return (addr & 0x0fffffff) + KERNEL_LOAD_ADDR;
> }
>
> -static void ppc_heathrow_reset(void *opaque)
> +static void ppc_heathrow_cpu_reset(void *opaque)
> {
> PowerPCCPU *cpu = opaque;
>
> @@ -127,7 +127,7 @@ static void ppc_heathrow_init(MachineState *machine)
>
> /* Set time-base frequency to 16.6 Mhz */
> cpu_ppc_tb_init(env, TBFREQ);
> - qemu_register_reset(ppc_heathrow_reset, cpu);
> + qemu_register_reset(ppc_heathrow_cpu_reset, cpu);
> }
>
> /* allocate RAM */
Technically this is a board level reset which just happens to pass the CPU for
the
opaque, so I'm not quite sold on this one (as an example look at mac_newworld.c
where
using the ELF load address for the PROM would require a dynamic NIP which is
most
conveniently accessed via a MachineState).
ATB,
Mark.
- [PATCH v2 0/5] Mac Old World ROM experiment, BALATON Zoltan, 2020/06/13
- [PATCH v2 2/5] mac_oldworld: Add machine ID register, BALATON Zoltan, 2020/06/13
- [PATCH v2 1/5] mac_oldworld: Allow loading binary ROM image, BALATON Zoltan, 2020/06/13
- [PATCH v2 4/5] mac_oldworld: Rename ppc_heathrow_reset reset to ppc_heathrow_cpu_reset, BALATON Zoltan, 2020/06/13
- [PATCH v2 5/5] mac_oldworld: Map macio to expected address at reset, BALATON Zoltan, 2020/06/13
- [PATCH v2 3/5] grackle: Set revision in PCI config to match hardware, BALATON Zoltan, 2020/06/13
- Re: [PATCH v2 0/5] Mac Old World ROM experiment, BALATON Zoltan, 2020/06/13