[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk
|
From: |
Paolo Bonzini |
|
Subject: |
Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk |
|
Date: |
Mon, 22 Jun 2020 15:25:36 +0200 |
|
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.6.0 |
On 22/06/20 15:07, Philippe Mathieu-Daudé wrote:
>>> +static int pcspk_audio_init_soundhw(ISABus *bus)
>>> +{
>>> + PCSpkState *s = pcspk_state;
>>> +
>>> + warn_report("'-soundhw pcspk' is deprecated, "
>>> + "please set a backend using '-global
>>> isa-pcspk.audiodev=<name>' instead");
> Markus's "Crazy shit around -global (pardon my french)"
> series instead suggest to use '-device ...':
> https://lists.gnu.org/archive/html/qemu-devel/2020-06/msg06667.html
> Could that work here?
No, this is a different issue. The problem with the floppy is that it
conflated two devices in one (controller and drive), while here the
device is builtin.
In this case -global could be replaced by a machine property, similar to
what is done for the block devices that back parallel flash. That
however is orthogonal to providing a good CLI for configuring audio.
Paolo
- [PATCH v3 10/19] audio: deprecate -soundhw hda, (continued)
- [PATCH v3 10/19] audio: deprecate -soundhw hda, Gerd Hoffmann, 2020/06/22
- [PATCH v3 16/19] softmmu: initialize spice and audio earlier, Gerd Hoffmann, 2020/06/22
- [PATCH v3 17/19] audio: rework pcspk_init(), Gerd Hoffmann, 2020/06/22
- [PATCH v3 15/19] pc_basic_device_init: drop no_vmport arg, Gerd Hoffmann, 2020/06/22
- [PATCH v3 14/19] pc_basic_device_init: drop has_pit arg, Gerd Hoffmann, 2020/06/22
- [PATCH v3 13/19] pc_basic_device_init: pass PCMachineState, Gerd Hoffmann, 2020/06/22
- [PATCH v3 18/19] audio: create pcspk device early, add audiodev alias., Gerd Hoffmann, 2020/06/22
- [PATCH v3 11/19] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/06/22
- Re: [PATCH v3 11/19] audio: deprecate -soundhw pcspk, Gerd Hoffmann, 2020/06/22
[PATCH v3 12/19] audio: add soundhw deprecation notice, Gerd Hoffmann, 2020/06/22
[PATCH v3 19/19] audio: set default value for pcspk.iobase property, Gerd Hoffmann, 2020/06/22
[PATCH v3 06/19] audio: deprecate -soundhw adlib, Gerd Hoffmann, 2020/06/22
[PATCH v3 08/19] audio: deprecate -soundhw gus, Gerd Hoffmann, 2020/06/22