[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus()
|
From: |
Andrew Jeffery |
|
Subject: |
Re: [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus() |
|
Date: |
Mon, 06 Jul 2020 11:09:42 +0930 |
|
User-agent: |
Cyrus-JMAP/3.3.0-dev0-576-gfe2cd66-fm-20200629.001-gfe2cd668 |
On Mon, 6 Jul 2020, at 08:11, Philippe Mathieu-Daudé wrote:
> All the callers of aspeed_i2c_get_bus() have a AspeedI2CState and
> cast it to a DeviceState with DEVICE(), then aspeed_i2c_get_bus()
> cast the DeviceState to an AspeedI2CState with ASPEED_I2C()...
>
> Simplify aspeed_i2c_get_bus() callers by using AspeedI2CState
> argument.
>
> Reviewed-by: Markus Armbruster <armbru@redhat.com>
> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
Reviewed-by: Andrew Jeffery <andrew@aj.id.au>
- [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus(), Philippe Mathieu-Daudé, 2020/07/05
- Re: [PATCH v2 1/5] hw/i2c/aspeed_i2c: Simplify aspeed_i2c_get_bus(),
Andrew Jeffery <=
- [PATCH v2 2/5] hw/i2c: Rename i2c_try_create_slave() as i2c_slave_new(), Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v2 3/5] hw/i2c: Rename i2c_realize_and_unref() as i2c_slave_realize_and_unref(), Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v2 5/5] hw/i2c: Document the I2C qdev helpers, Philippe Mathieu-Daudé, 2020/07/05
- [PATCH v2 4/5] hw/i2c: Rename i2c_create_slave() as i2c_slave_create_simple(), Philippe Mathieu-Daudé, 2020/07/05
- Re: [PATCH v2 0/5] hw/i2c: Rename method names for consistency and add documentation, Philippe Mathieu-Daudé, 2020/07/10