[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction

From: Matthieu Bucchianeri
Subject: [PATCH] target/ppc: Fix TCG leak with the evmwsmiaa instruction
Date: Mon, 27 Jul 2020 10:21:14 -0700

Fix double-call to tcg_temp_new_i64(), where a temp is allocated both at
declaration time and further down the implementation of gen_evmwsmiaa().

Note that gen_evmwsmia() and gen_evmwsmiaa() are still not implemented
correctly, as they invoke gen_evmwsmi() which may return early, but the
return is not propagated. This will be fixed in my patch for bug #1888918.

Signed-off-by: Matthieu Bucchianeri <matthieu.bucchianeri@leostella.com>
 target/ppc/translate/spe-impl.inc.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/target/ppc/translate/spe-impl.inc.c 
index 36b4d5654d..42a0d1cffb 100644
--- a/target/ppc/translate/spe-impl.inc.c
+++ b/target/ppc/translate/spe-impl.inc.c
@@ -528,14 +528,14 @@ static inline void gen_evmwsmia(DisasContext *ctx)


 static inline void gen_evmwsmiaa(DisasContext *ctx)
-    TCGv_i64 acc = tcg_temp_new_i64();
-    TCGv_i64 tmp = tcg_temp_new_i64();
+    TCGv_i64 acc;
+    TCGv_i64 tmp;

     gen_evmwsmi(ctx);           /* rD := rA * rB */

     acc = tcg_temp_new_i64();
     tmp = tcg_temp_new_i64();


LeoStella, LLC
A joint venture of Thales Alenia Space and Spaceflight Industries

12501 E Marginal Way S • Tukwila, WA 98168

Proprietary Document: This document may contain trade secrets or otherwise 
proprietary and confidential information owned by LeoStella LLC. It is intended 
only for the individual addressee and may not be copied, distributed, or 
otherwise disclosed without LeoStella LLC express prior written authorization.
Export Controlled: This document may contain technical data whose export is 
restricted by the Arms Export Control Act (Title 22, U.S.C., Sec 2751 et seq.) 
or the Export Administration Act of 1979, as amended, Title 50,U.S.C., app 2401 
et seq. Violation of these export laws are subject to severe criminal 
penalties. Recipient shall not export, re-export, or otherwise transfer or 
share this document to any foreign person (as defined by U.S. export laws) 
without advance written authorization from LeoStella LLC.

reply via email to

[Prev in Thread] Current Thread [Next in Thread]