Re: [PATCH 2/2] qom: Use DECLARE_INTERFACE_CHECKER macro

[Eduardo Habkost]

On Thu, Sep 17, 2020 at 10:44:34AM +1000, David Gibson wrote:
[...]
> > diff --git a/include/hw/acpi/acpi_dev_interface.h 
> > b/include/hw/acpi/acpi_dev_interface.h
> > index 9adf1e4706..96aa63919a 100644
> > --- a/include/hw/acpi/acpi_dev_interface.h
> > +++ b/include/hw/acpi/acpi_dev_interface.h
> > @@ -21,9 +21,8 @@ typedef enum {
> >  typedef struct AcpiDeviceIfClass AcpiDeviceIfClass;
> >  DECLARE_CLASS_CHECKERS(AcpiDeviceIfClass, ACPI_DEVICE_IF,
> >                         TYPE_ACPI_DEVICE_IF)
> > -#define ACPI_DEVICE_IF(obj) \
> > -     INTERFACE_CHECK(AcpiDeviceIf, (obj), \
> > -                     TYPE_ACPI_DEVICE_IF)
> > +DECLARE_INTERFACE_CHECKER(AcpiDeviceIf, ACPI_DEVICE_IF,
> > +                          TYPE_ACPI_DEVICE_IF)
> >  
> >  typedef struct AcpiDeviceIf AcpiDeviceIf;

This is broken because the typedef needs to be before
DECLARE_INTERFACE_CHECKER.  I will send v2.

-- 
Eduardo