[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init()
From: |
Laurent Vivier |
Subject: |
Re: [PATCH] hw/rtc/m48t59: Simplify m48t59_init() |
Date: |
Thu, 24 Sep 2020 17:00:21 +0200 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101 Thunderbird/68.11.0 |
Le 24/09/2020 à 16:53, Philippe Mathieu-Daudé a écrit :
> On 9/16/20 4:50 AM, David Gibson wrote:
>> On Mon, Sep 14, 2020 at 12:24:25PM +0200, Philippe Mathieu-Daudé wrote:
>>> As the 'io_base' argument of m48t59_init() is unused (set to 0),
>>> remove it to simplify.
>>> To create a device on the ISA bus, m48t59_init_isa() is the
>>> preferred function to use.
>>>
>>> Signed-off-by: Philippe Mathieu-Daudé <f4bug@amsat.org>
>>> ---
>>> include/hw/rtc/m48t59.h | 2 +-
>>> hw/ppc/ppc405_boards.c | 2 +-
>>> hw/rtc/m48t59.c | 10 ++--------
>>> hw/sparc/sun4m.c | 2 +-
>>> hw/sparc64/sun4u.c | 2 +-
>>> 5 files changed, 6 insertions(+), 12 deletions(-)
>>
>> ppc part
>> Acked-by: David Gibson <david@gibson.dropbear.id.au>
>
> Thanks!
>
> Can this go via qemu-trivial@?
Yes, but more reviewers would help. Mark?
Thanks,
Laurent