[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 0/6] m48t59: remove legacy init functions

From: Mark Cave-Ayland
Subject: Re: [PATCH 0/6] m48t59: remove legacy init functions
Date: Sun, 18 Oct 2020 17:13:18 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.3.1

On 17/10/2020 21:13, BALATON Zoltan via wrote:

This is inspired by Mark's series:


and implements what I've suggested in review of that series to
simplify it and avoid code churn if implementing my suggestion later.


BALATON Zoltan (4):
   mt48t59: Set default value of base-year property to 1968
   sun4m: use qdev instead of legacy m48t59_init() function
   sun4u: use qdev instead of legacy m48t59_init() function
   ppc405_boards: use qdev instead of legacy m48t59_init() function

Mark Cave-Ayland (2):
   m48t59-isa: remove legacy m48t59_init_isa() function
   m48t59: remove legacy m48t59_init() function

  hw/ppc/ppc405_boards.c  |  3 ++-
  hw/rtc/m48t59-isa.c     | 25 -------------------------
  hw/rtc/m48t59.c         | 37 +------------------------------------
  hw/sparc/sun4m.c        |  5 +++--
  hw/sparc64/sun4u.c      |  6 ++++--
  include/hw/rtc/m48t59.h |  6 ------
  6 files changed, 10 insertions(+), 72 deletions(-)

Unfortunately this arrived too late - I'd already finished the tagging and local testing, but didn't get a chance to do the final PR before having to head out yesterday.

I think most people here agree that this code could be improved, but I'm not clear that this is the right solution given that Artyom has already pointed out that 40p uses 1900 as the base year. There would also be an overlap with the ideas that Philippe has expressed in this thread which would cause more code churn later, so if this is something that interests you I would suggest starting a separate thread to gain consensus as to the desired solution first before working on an updated series.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]