[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.0 v2 2/3] spapr/xive: Fix size of END table and number

From: Cédric Le Goater
Subject: Re: [PATCH for-6.0 v2 2/3] spapr/xive: Fix size of END table and number of claimed IPIs
Date: Fri, 4 Dec 2020 09:46:31 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.4.0

>> I don't think we need much more than patch 1 which clarifies the 
>> nature of the values being manipulated, quantities vs. numbering.
>> The last 2 patches are adding complexity to try to optimize the 
>> XIVE VP space in a case scenario which is not very common (vSMT). 
>> May be it's not worth it. 
> Well, the motivation isn't about optimization really since
> a non-default vSMT setting already wastes VP space because
> of the vCPU spacing. 

I don't see any VPs being wasted when not using vSMT. What's
your command line ?

> This is more about not using values
> with wrong semantics in the code to avoid confusion in
> future changes.


> I agree though that the extra complexity, especially the
> compat crust, might be excessive. 

It's nice and correct but it seems a bit like extra noise 
if the default case is not wasting VPs. Let's check that 

> So maybe I should just
> add comments in the code to clarify when we're using the
> wrong semantics ?

yes. I think this is enough.



reply via email to

[Prev in Thread] Current Thread [Next in Thread]