[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
[PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_re
From: |
David Gibson |
Subject: |
[PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_request() |
Date: |
Wed, 10 Mar 2021 15:10:01 +1100 |
From: Daniel Henrique Barboza <danielhb413@gmail.com>
We are asserting the existence of the first DRC LMB after sending unplug
requests to all LMBs of the DIMM, where every DRC is being asserted
inside the loop. This means that the first DRC is being asserted twice.
Remove the duplicated assert.
Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Message-Id: <20210302141019.153729-2-danielhb413@gmail.com>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
---
hw/ppc/spapr.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index aca3ef9d58..b579830832 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3703,7 +3703,6 @@ static void spapr_memory_unplug_request(HotplugHandler
*hotplug_dev,
drc = spapr_drc_by_id(TYPE_SPAPR_DRC_LMB,
addr_start / SPAPR_MEMORY_BLOCK_SIZE);
- g_assert(drc);
spapr_hotplug_req_remove_by_count_indexed(SPAPR_DR_CONNECTOR_TYPE_LMB,
nr_lmbs, spapr_drc_index(drc));
}
--
2.29.2
- [PULL 07/20] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request(), (continued)
- [PULL 07/20] spapr: rename spapr_drc_detach() to spapr_drc_unplug_request(), David Gibson, 2021/03/09
- [PULL 11/20] spapr_drc.c: add hotunplug timeout for CPUs, David Gibson, 2021/03/09
- [PULL 12/20] spapr_drc.c: use DRC reconfiguration to cleanup DIMM unplug state, David Gibson, 2021/03/09
- [PULL 14/20] hw/ppc: e500: Add missing <ranges> in the eTSEC node, David Gibson, 2021/03/09
- [PULL 17/20] qemu_timer.c: add timer_deadline_ms() helper, David Gibson, 2021/03/09
- [PULL 13/20] hw/net: fsl_etsec: Fix build error when HEX_DUMP is on, David Gibson, 2021/03/09
- [PULL 15/20] spapr.c: add 'unplug already in progress' message for PHB unplug, David Gibson, 2021/03/09
- [PULL 05/20] pseries: Update SLOF firmware image, David Gibson, 2021/03/09
- [PULL 01/20] hw/display/sm501: Remove dead code for non-32-bit RGB surfaces, David Gibson, 2021/03/09
- [PULL 08/20] docs/system: Extend PPC section, David Gibson, 2021/03/09
- [PULL 19/20] spapr.c: remove duplicated assert in spapr_memory_unplug_request(),
David Gibson <=
- [PULL 16/20] spapr_pci.c: add 'unplug already in progress' message for PCI unplug, David Gibson, 2021/03/09
- [PULL 20/20] spapr.c: send QAPI event when memory hotunplug fails, David Gibson, 2021/03/09
- [PULL 18/20] target/ppc: fix icount support on Book-e vms accessing SPRs, David Gibson, 2021/03/09
- Re: [PULL 00/20] ppc-for-6.0 queue 20210310, Bin Meng, 2021/03/09
- Re: [PULL 00/20] ppc-for-6.0 queue 20210310, Ivan Warren, 2021/03/10