[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v5 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt

From: Gerd Hoffmann
Subject: Re: [PATCH v5 4/8] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it
Date: Wed, 10 Mar 2021 11:17:23 +0100

> >> That said, I don't think breaking compat is a problem: that's only an
> >> issue where we actually have versioned machine types, which covers
> >> only pc, pseries, arm virt and a very few others.  I don't think this
> >> device was used on any of them.
> > 
> > Except 'vt82c686b-usb-uhci' is a generic PCI device that anyone can
> > instantiate, so it's not actually Fuloong specific.
> I tend to see this as a bug, as this is a function specific to the
> southbridge chipset and isn't meant to be used apart...

Strictly speaking this is true for all other uhci devices too,
they are piix / q35 specific.

> If this isn't a feature but really a bug, a simple way to clean this
> is to make struct UHCIInfo and usb_uhci_common_realize() public, and
> type_register "vt82c686b-usb-uhci" elsewhere.
> Gerd would that work with you?

Fine with me.

But given that all usb_uhci_vt82c686b_realize() does is tweak pci config
space a bit we can IMHO also live with just fine the current state.

Your choice.

take care,

reply via email to

[Prev in Thread] Current Thread [Next in Thread]