[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime a
Re: [PATCH 05/14] migrate: remove QMP/HMP commands for speed, downtime and cache size
Thu, 11 Mar 2021 19:18:54 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.0
On 11/03/21 12:54, Dr. David Alan Gilbert wrote:
* Daniel P. Berrangé (email@example.com) wrote:
The generic 'migrate_set_parameters' command handle all types of param.
Only the QMP commands were documented in the deprecations page, but the
rationale for deprecating applies equally to HMP, and the replacements
exist. Furthermore the HMP commands are just shims to the QMP commands,
so removing the latter breaks the former unless they get re-implemented.
Signed-off-by: Daniel P. Berrangé <firstname.lastname@example.org>
Yes OK; ouch that's going to break my 7 years of instinctive
'migrate_set_speed 10G' typing, but it's probably the right thing to do.
migrate_set_speed should remain if it is not changed to have a sane default.