[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] spapr: Assert DIMM unplug state in spapr_memory_unplug()

From: Daniel Henrique Barboza
Subject: Re: [PATCH] spapr: Assert DIMM unplug state in spapr_memory_unplug()
Date: Mon, 15 Mar 2021 09:11:56 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0

On 3/13/21 4:23 AM, Greg Kurz wrote:
spapr_memory_unplug() is the last step of the hot unplug sequence.
It is indirectly called by:


and spapr_lmb_release() already buys us that DIMM unplug state is
present : it gets restored with spapr_recover_pending_dimm_state()
if missing.

g_assert() that spapr_pending_dimm_unplugs_find() cannot return NULL
in spapr_memory_unplug() to make this clear and silence Coverity.

Fixes: Coverity CID 1450767
Signed-off-by: Greg Kurz <groug@kaod.org>

Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>

  hw/ppc/spapr.c |    3 +++
  1 file changed, 3 insertions(+)

diff --git a/hw/ppc/spapr.c b/hw/ppc/spapr.c
index d56418ca2942..73a06df3b1b1 100644
--- a/hw/ppc/spapr.c
+++ b/hw/ppc/spapr.c
@@ -3660,6 +3660,9 @@ static void spapr_memory_unplug(HotplugHandler 
*hotplug_dev, DeviceState *dev)
      SpaprMachineState *spapr = SPAPR_MACHINE(hotplug_dev);
      SpaprDimmState *ds = spapr_pending_dimm_unplugs_find(spapr, PC_DIMM(dev));
+ /* We really shouldn't get this far without anything to unplug */
+    g_assert(ds);
      pc_dimm_unplug(PC_DIMM(dev), MACHINE(hotplug_dev));
      spapr_pending_dimm_unplugs_remove(spapr, ds);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]