[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region direc
Re: [PATCH 2/5] hw/arm/aspeed: Do not sysbus-map mmio flash region directly, use alias
Wed, 17 Mar 2021 20:00:19 +0100
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.0
On 3/17/21 7:30 PM, Cédric Le Goater wrote:
> On 3/12/21 7:28 PM, Philippe Mathieu-Daudé wrote:
>> The flash mmio region is exposed as an AddressSpace.
>> AddressSpaces must not be sysbus-mapped, therefore map
>> the region using an alias.
>> Signed-off-by: Philippe Mathieu-Daudé <email@example.com>
> That does the trick but you need an extra change in the model.
> The fixes are in my aspeed-6.0 branch on GH and they survive the last
> patch of your series :
> [PATCH 5/5] memory: Make sure root MR won't be added as subregion
I wondered about changing DMA_FLASH_ADDR() wasn't sure the tests
would use the flash.
> I will upstream for 6.1.