[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base v

From: BALATON Zoltan
Subject: Re: [PATCH v10 3/7] vt82c686: Introduce abstract TYPE_VIA_ISA and base vt82c686b_isa on it
Date: Wed, 17 Mar 2021 20:24:07 +0100 (CET)

On Wed, 17 Mar 2021, Philippe Mathieu-Daudé wrote:
On 3/17/21 2:17 AM, BALATON Zoltan wrote:
To allow reusing ISA bridge emulation for vt8231_isa move the device
state of vt82c686b_isa emulation in an abstract via_isa class. This
change breaks migration back compatibility but this is not an issue
for Fuloong2E machine which is not versioned or migration supported.

Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
 hw/isa/vt82c686.c        | 70 ++++++++++++++++++++++------------------
 include/hw/pci/pci_ids.h |  2 +-
 2 files changed, 40 insertions(+), 32 deletions(-)

Now than "hw/usb: Extract VT82C686 UHCI PCI function into a new unit"
is merged as commit 6f2bcd5fc84, this is acceptable IMHO, so:
Reviewed-by: Philippe Mathieu-Daudé <f4bug@amsat.org>

Still don't see what does the USB function do with this that does not have any reference to USB but thanks. Will you send a pull requests with the series?


reply via email to

[Prev in Thread] Current Thread [Next in Thread]