|
From: | Richard Henderson |
Subject: | Re: [PATCH 2/4] target/ppc: added solutions for building with disable-tcg |
Date: | Mon, 12 Apr 2021 08:40:47 -0700 |
User-agent: | Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 4/11/21 10:08 PM, David Gibson wrote:
Not directly related to what you're trying to accomplish here, but the whole vscr_sat thing looks really weird. I have no idea why we're splitting out the storage of VSCR[SAT] for the TCG case at all. If you wanted to clean that up as a preliminary, I'd be grateful.
That's about efficiently implementing the vector saturation instructions in TCG. See GEN_VXFORM_SAT in translate/vmx-impl.c.inc.
The SAT bit is represented as a vector that e.g. compares the result of addition with the result of saturating addition. We don't need to resolve that to a single bit until the VSCR register is read.
r~
[Prev in Thread] | Current Thread | [Next in Thread] |