[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic
From: |
Bruno Piazera Larsen |
Subject: |
Re: [PATCH v2 7/7] target/ppc: isolated cpu init from translation logic |
Date: |
Fri, 30 Apr 2021 11:35:36 -0300 |
User-agent: |
Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.7.1 |
On 30/04/2021 01:25, Richard Henderson
wrote:
On
4/29/21 9:21 AM, Bruno Larsen (billionai) wrote:
@@ -49,7 +54,12 @@ static inline void
vscr_init(CPUPPCState *env, uint32_t val)
{
/* Altivec always uses round-to-nearest */
set_float_rounding_mode(float_round_nearest_even,
&env->vec_status);
- helper_mtvscr(env, val);
+ /*
+ * This comment is here just so the project will build.
+ * The current solution is in another patch and will be
+ * added when we figure out an internal fork of qemu
+ */
+ /* helper_mtvscr(env, val); */
}
(1) this is a separate change to splitting out cpu_init.c.
Oh, yeah. I was going to remove this change for now, it was for
building with disable-tcg, which is still not working
(2) you
can't even do this without introducing a regression.
The plan is to not just remove, but change with a common
function. on a future series, though.
I'm just slightly concerned now that make check has not seen
anything...
r~
--
Bruno Piazera Larsen
Departamento Computação Embarcada
Analista de Software Trainee