Re: [PATCH v3 3/7] target/ppc: remove unnecessary SPR functions

[Richard Henderson]

On 4/30/21 12:35 PM, Bruno Larsen (billionai) wrote:
> Removed functions gen_read_xer and gen_write_xer, moving their logic
> directly into spr_read_xer and spr_write_xer, respectively.
>
> Signed-off-by: Bruno Larsen (billionai) <bruno.larsen@eldorado.org.br>
> ---

"Unnecessary" makes me believe that the code isn't used at all.
A better description for this patch is

---
target/ppc: Fold gen_{read,write}_xer into spr_{read,write}_xer

Fold these functions into their single caller.
---

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~