Re: [PATCH v4 15/15] hw/i2c: Introduce i2c_start_recv() and i2c_start_send()

[Richard Henderson]

On 6/16/21 2:42 PM, Philippe Mathieu-Daudé wrote:
> To ease reviewing code using the I2C bus API, introduce the
> i2c_start_recv() and i2c_start_send() helpers which don't
> take the confusing 'is_recv' boolean argument.
>
> Use these new helpers in the SMBus / AUX bus models.
>
> Suggested-by: Richard Henderson<richard.henderson@linaro.org>
> Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>
> ---
>   include/hw/i2c/i2c.h  | 24 ++++++++++++++++++++++++
>   hw/i2c/core.c         | 10 ++++++++++
>   hw/i2c/pm_smbus.c     |  4 ++--
>   hw/i2c/smbus_master.c | 22 +++++++++++-----------
>   hw/misc/auxbus.c      | 12 ++++++------
>   5 files changed, 53 insertions(+), 19 deletions(-)

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~