[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c

From: Richard Henderson
Subject: Re: [PATCH] tcg: Avoid including 'trace-tcg.h' in target translate.c
Date: Tue, 22 Jun 2021 10:50:30 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.8.1

On 6/22/21 9:15 AM, Philippe Mathieu-Daudé wrote:
The root trace-events only declares a single TCG event:

   $ git grep -w tcg trace-events
   trace-events:115:# tcg/tcg-op.c
   trace-events:137:vcpu tcg guest_mem_before(TCGv vaddr, uint16_t info) "info=%d", 
"vaddr=0x%016"PRIx64" info=%d"

and only a tcg/tcg-op.c uses it:

   $ git grep -l trace_guest_mem_before_tcg

therefore it is pointless to include "trace-tcg.h" in each target
(because it is not used). Remove it.

Signed-off-by: Philippe Mathieu-Daudé<f4bug@amsat.org>

Thanks, queued.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]