[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH] mv64361: Remove extra break from a switch case

From: BALATON Zoltan
Subject: Re: [PATCH] mv64361: Remove extra break from a switch case
Date: Mon, 12 Jul 2021 16:38:43 +0200 (CEST)

On Mon, 12 Jul 2021, Philippe Mathieu-Daudé wrote:
On 7/12/21 3:11 PM, BALATON Zoltan wrote:
The switch case of writing PCI 1 IO base address had an extra break
statement that made part of the code unreachable. This did not cause a
problem as guests ususally leave this register at its default value.

Reported-by: Coverity (CID 1458135)

Fixes: dcdf98a9015 ("Add emulation of Marvell MV64361 PPC system

Yeah, why not. Feel free to add the Fixes tag when merging, although that's the only commit this file had so far so linking to it does not seem to add much more info.


Signed-off-by: BALATON Zoltan <balaton@eik.bme.hu>
 hw/pci-host/mv64361.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/hw/pci-host/mv64361.c b/hw/pci-host/mv64361.c
index 20510d8680..92b0f5d047 100644
--- a/hw/pci-host/mv64361.c
+++ b/hw/pci-host/mv64361.c
@@ -687,7 +687,6 @@ static void mv64361_write(void *opaque, hwaddr addr, 
uint64_t val,
     case MV64340_PCI_1_IO_BASE_ADDR:
         s->pci[1].io_base = val & 0x30fffffULL;
-        break;
         if (!(s->cpu_conf & BIT(27))) {
             s->pci[1].remap[4] = (val & 0xffffULL) << 16;

reply via email to

[Prev in Thread] Current Thread [Next in Thread]