[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v7 7/7] memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in a
From: |
Michael S. Tsirkin |
Subject: |
Re: [PATCH v7 7/7] memory_hotplug.c: send DEVICE_UNPLUG_GUEST_ERROR in acpi_memory_hotplug_write() |
Date: |
Mon, 30 Aug 2021 18:21:51 -0400 |
On Tue, Aug 24, 2021 at 09:48:35PM -0300, Daniel Henrique Barboza wrote:
> MEM_UNPLUG_ERROR is deprecated since the introduction of
> DEVICE_UNPLUG_GUEST_ERROR. Keep emitting both while the deprecation of
> MEM_UNPLUG_ERROR is pending.
>
> CC: Michael S. Tsirkin <mst@redhat.com>
> CC: Igor Mammedov <imammedo@redhat.com>
> Reviewed-by: Greg Kurz <groug@kaod.org>
> Signed-off-by: Daniel Henrique Barboza <danielhb413@gmail.com>
Acked-by: Michael S. Tsirkin <mst@redhat.com>
feel free to include with the rest of the patchset
> ---
> hw/acpi/memory_hotplug.c | 9 +++++++++
> 1 file changed, 9 insertions(+)
>
> diff --git a/hw/acpi/memory_hotplug.c b/hw/acpi/memory_hotplug.c
> index 6a71de408b..d0fffcf787 100644
> --- a/hw/acpi/memory_hotplug.c
> +++ b/hw/acpi/memory_hotplug.c
> @@ -8,6 +8,7 @@
> #include "qapi/error.h"
> #include "qapi/qapi-events-acpi.h"
> #include "qapi/qapi-events-machine.h"
> +#include "qapi/qapi-events-qdev.h"
>
> #define MEMORY_SLOTS_NUMBER "MDNR"
> #define MEMORY_HOTPLUG_IO_REGION "HPMR"
> @@ -178,8 +179,16 @@ static void acpi_memory_hotplug_write(void *opaque,
> hwaddr addr, uint64_t data,
> hotplug_handler_unplug(hotplug_ctrl, dev, &local_err);
> if (local_err) {
> trace_mhp_acpi_pc_dimm_delete_failed(mem_st->selector);
> +
> + /*
> + * Send both MEM_UNPLUG_ERROR and DEVICE_UNPLUG_GUEST_ERROR
> + * while the deprecation of MEM_UNPLUG_ERROR is
> + * pending.
> + */
> qapi_event_send_mem_unplug_error(dev->id ? : "",
>
> error_get_pretty(local_err));
> + qapi_event_send_device_unplug_guest_error(!!dev->id, dev->id,
> +
> dev->canonical_path);
> error_free(local_err);
> break;
> }
> --
> 2.31.1
- Re: [PATCH v7 4/7] qapi/qdev.json: fix DEVICE_DELETED parameters doc, (continued)