[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v2 02/19] host-utils: move abs64() to host-utils as uabs64()
From: |
Eduardo Habkost |
Subject: |
Re: [PATCH v2 02/19] host-utils: move abs64() to host-utils as uabs64() |
Date: |
Tue, 31 Aug 2021 14:20:17 -0400 |
On Tue, Aug 31, 2021 at 01:39:50PM -0300, Luis Pires wrote:
> Move abs64 to host-utils as uabs64, so it can be used elsewhere.
> The function was renamed to uabs64 and modified to return an
> unsigned value. This avoids the undefined behavior for common
> abs implementations, where abs of the most negative value is
> undefined.
>
> Signed-off-by: Luis Pires <luis.pires@eldorado.org.br>
Reviewed-by: Eduardo Habkost <ehabkost@redhat.com>
In case you need to send a new version of the series, I'd suggest
separating this into two patches: creation of the uabs64()
function in host-utils, and then changing the KVM PIT code to use
the new uabs64() function. This way, the rest of your series
won't depend on the KVM PIT changes, helping bisectability and
backportability.
--
Eduardo
- [PATCH v2 00/19] target/ppc: DFP instructions using decodetree, Luis Pires, 2021/08/31
- [PATCH v2 01/19] host-utils: Fix overflow detection in divu128(), Luis Pires, 2021/08/31
- [PATCH v2 02/19] host-utils: move abs64() to host-utils as uabs64(), Luis Pires, 2021/08/31
- [PATCH v2 03/19] host-utils: move checks out of divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 04/19] host-utils: add 128-bit quotient support to divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 05/19] host-utils: add unit tests for divu128/divs128, Luis Pires, 2021/08/31
- [PATCH v2 06/19] libdecnumber: introduce decNumberFrom[U]Int128, Luis Pires, 2021/08/31
- [PATCH v2 07/19] target/ppc: Move REQUIRE_ALTIVEC/VECTOR to translate.c, Luis Pires, 2021/08/31
- [PATCH v2 08/19] target/ppc: Introduce REQUIRE_FPU, Luis Pires, 2021/08/31