[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 8/9] pci: Export pci_for_each_device_under_bus*()

From: Matthew Rosato
Subject: Re: [PULL 8/9] pci: Export pci_for_each_device_under_bus*()
Date: Tue, 2 Nov 2021 09:54:27 -0400
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 11/1/21 7:44 PM, Michael S. Tsirkin wrote:
From: Peter Xu <peterx@redhat.com>

They're actually more commonly used than the helper without _under_bus, because
most callers do have the pci bus on hand.  After exporting we can switch a lot
of the call sites to use these two helpers.

Reviewed-by: David Hildenbrand <david@redhat.com>
Reviewed-by: Eric Auger <eric.auger@redhat.com>
Signed-off-by: Peter Xu <peterx@redhat.com>
Message-Id: <20211028043129.38871-3-peterx@redhat.com>
Reviewed-by: Michael S. Tsirkin <mst@redhat.com>
Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
Acked-by: David Gibson <david@gibson.dropbear.id.au>
  include/hw/pci/pci.h       |  5 +++++
  hw/i386/acpi-build.c       |  5 ++---
  hw/pci/pci.c               | 10 +++++-----
  hw/pci/pcie.c              |  4 +---
  hw/ppc/spapr_pci.c         | 12 +++++-------
  hw/ppc/spapr_pci_nvlink2.c |  7 +++----
  hw/ppc/spapr_pci_vfio.c    |  4 ++--
  hw/s390x/s390-pci-bus.c    |  5 ++---

Looks like I wasn't on CC for the initial patches so I missed it (oops) but I did just verify the s390x changes now, LGTM. Thanks!

If needed, for s390 changes:
Acked-by: Matthew Rosato <mjrosato@linux.ibm.com>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]