[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PULL 03/54] target/ppc: Move load and store floating point instruct

From: Laurent Vivier
Subject: Re: [PULL 03/54] target/ppc: Move load and store floating point instructions to decodetree
Date: Wed, 10 Nov 2021 17:33:08 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 09/11/2021 06:51, David Gibson wrote:
From: Fernando Eckhardt Valle <phervalle@gmail.com>

Move load floating point instructions (lfs, lfsu, lfsx, lfsux, lfd, lfdu, lfdx, 
and store floating point instructions(stfs, stfsu, stfsx, stfsux, stfd, stfdu, 
stfdux) from legacy system to decodetree.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>
Signed-off-by: Fernando Eckhardt Valle <fernando.valle@eldorado.org.br>
Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
Message-Id: <20211029202424.175401-4-matheus.ferst@eldorado.org.br>
Signed-off-by: David Gibson <david@gibson.dropbear.id.au>
  target/ppc/insn32.decode           |  24 +++
  target/ppc/translate/fp-impl.c.inc | 247 +++++++++--------------------
  target/ppc/translate/fp-ops.c.inc  |  29 ----
  3 files changed, 95 insertions(+), 205 deletions(-)

This patch breaks qemu linux-user with an ubuntu bionic chroot.

The fix proposed by Matheus [1] fixes it for me.
When will it be merged?
It's needed in 6.2


[1] c799859a-4fdc-9d69-7a87-5e69cee15ef3@eldorado.org.br">https://patchew.org/QEMU/20211029202424.175401-1-matheus.ferst@eldorado.org.br/20211029202424.175401-4-matheus.ferst@eldorado.org.br/#c799859a-4fdc-9d69-7a87-5e69cee15ef3@eldorado.org.br

diff --git a/target/ppc/translate/fp-impl.c.inc 
index d1dbb1b96b..c9e05201d9 100644
--- a/target/ppc/translate/fp-impl.c.inc
+++ b/target/ppc/translate/fp-impl.c.inc
@@ -1328,7 +1328,7 @@ static bool do_lsfpsd(DisasContext *ctx, int rt, int ra, 
TCGv displ,
         set_fpr(rt, t0);
     if (update) {
-        tcg_gen_mov_tl(cpu_gpr[rt], ea);
+        tcg_gen_mov_tl(cpu_gpr[ra], ea);

reply via email to

[Prev in Thread] Current Thread [Next in Thread]