[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_revers

From: Cédric Le Goater
Subject: Re: [PATCH for-6.2] tests/tcg/ppc64le: Fix compile flags for byte_reverse
Date: Wed, 17 Nov 2021 19:12:38 +0100
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.2.0

On 11/17/21 18:33, Richard Henderson wrote:
With a host compiler new enough to recognize power10 insns,
CROSS_CC_HAS_POWER10 is true, but we do not supply the -cpu
option to the compiler, resulting in

/tmp/ccAVdYJd.s: Assembler messages:
/tmp/ccAVdYJd.s:49: Error: unrecognized opcode: `brh'
/tmp/ccAVdYJd.s:78: Error: unrecognized opcode: `brw'
/tmp/ccAVdYJd.s:107: Error: unrecognized opcode: `brd'
make[2]: *** [byte_reverse] Error 1

Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

This looks fine. Queued for 6.2

I would need some education on how to run these tests and reproduce.



  tests/tcg/ppc64le/Makefile.target | 12 +++---------
  1 file changed, 3 insertions(+), 9 deletions(-)

diff --git a/tests/tcg/ppc64le/Makefile.target 
index 5e65b1590d..ba2fde5ff1 100644
--- a/tests/tcg/ppc64le/Makefile.target
+++ b/tests/tcg/ppc64le/Makefile.target
@@ -9,18 +9,12 @@ PPC64LE_TESTS=bcdsub
  bcdsub: CFLAGS += -mpower8-vector
-PPC64LE_TESTS += byte_reverse
+PPC64LE_TESTS += byte_reverse
+byte_reverse: CFLAGS += -mcpu=power10
  run-byte_reverse: QEMU_OPTS+=-cpu POWER10
  run-plugin-byte_reverse-with-%: QEMU_OPTS+=-cpu POWER10
-       $(call skip-test, "BUILD of $@", "missing compiler support")
-       $(call skip-test, "RUN of byte_reverse", "not built")
-       $(call skip-test, "RUN of byte_reverse ($*)", "not built")
PPC64LE_TESTS += signal_save_restore_xer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]