Re: [PATCH v4 14/47] target/ppc: implement vstri[bh][lr]

[Richard Henderson]

On 2/22/22 04:36, matheus.ferst@eldorado.org.br wrote:
> From: Matheus Ferst <matheus.ferst@eldorado.org.br>
>
> Signed-off-by: Matheus Ferst <matheus.ferst@eldorado.org.br>
> ---
> v4:
>   - vstri helpers return CR field (rth)
> ---
>   target/ppc/helper.h                 |  4 ++++
>   target/ppc/insn32.decode            | 10 ++++++++++
>   target/ppc/int_helper.c             | 28 +++++++++++++++++++++++++++
>   target/ppc/translate/vmx-impl.c.inc | 30 +++++++++++++++++++++++++++++
>   4 files changed, 72 insertions(+)
>
> diff --git a/target/ppc/helper.h b/target/ppc/helper.h
> index 303a29fb5a..269150b197 100644
> --- a/target/ppc/helper.h
> +++ b/target/ppc/helper.h
> @@ -211,6 +211,10 @@ DEF_HELPER_4(VINSBLX, void, env, avr, i64, tl)
>   DEF_HELPER_4(VINSHLX, void, env, avr, i64, tl)
>   DEF_HELPER_4(VINSWLX, void, env, avr, i64, tl)
>   DEF_HELPER_4(VINSDLX, void, env, avr, i64, tl)
> +DEF_HELPER_2(VSTRIBL, i32, avr, avr)
> +DEF_HELPER_2(VSTRIBR, i32, avr, avr)
> +DEF_HELPER_2(VSTRIHL, i32, avr, avr)
> +DEF_HELPER_2(VSTRIHR, i32, avr, avr)

Oh, DEF_HELPER_FLAGS_2 with TCG_CALL_NO_RWG.
I should have thought of this wrt the other helpers you're touching in this series -- 
those that only modify vector registers should use this.

Otherwise,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~