Re: [PATCH v4 33/47] target/ppc: Implement xxgenpcv[bhwd]m instruction

[Richard Henderson]

On 2/22/22 04:36, matheus.ferst@eldorado.org.br wrote:
> +#define XXGENPCV(NAME, SZ) \
> +void helper_##NAME(ppc_vsr_t *t, ppc_vsr_t *b, target_ulong imm)            \
> +{                                                                           \
> +    ppc_vsr_t tmp = { .u64 = { 0, 0 } };                                    \
> +                                                                            \
> +    switch (imm) {                                                          \

You should split the helper and not pass down imm.


r~