Re: [PATCH v5 04/49] target/ppc: vmulh* instructions without helpers

[Richard Henderson]

On 2/25/22 11:08, matheus.ferst@eldorado.org.br wrote:
> +static void do_vx_vmulhw_i64(TCGv_i64 t, TCGv_i64 a, TCGv_i64 b, bool sign)
> +{
> +    TCGv_i64 hh, lh, temp;
> +
> +    uint64_t c;
> +    hh = tcg_temp_new_i64();
> +    lh = tcg_temp_new_i64();
> +    temp = tcg_temp_new_i64();
> +
> +    c = 0xFFFFFFFF;
> +
> +    if (sign) {
> +        tcg_gen_ext32s_i64(lh, a);
> +        tcg_gen_ext32s_i64(temp, b);
> +    } else {
> +        tcg_gen_andi_i64(lh, a, c);
> +        tcg_gen_andi_i64(temp, b, c);

Nit: tcg_gen_ext32u_i64.

> +    tcg_gen_andi_i64(hh, hh, c << 32);
> +    tcg_gen_or_i64(t, hh, lh);

Nit: tcg_gen_deposit_i64(t, hh, lh, 0, 32);

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


r~