[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v1] hw/ppc: change indentation to spaces from TABs

From: Thomas Huth
Subject: Re: [PATCH v1] hw/ppc: change indentation to spaces from TABs
Date: Mon, 11 Apr 2022 08:45:09 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.6.0

On 08/04/2022 21.19, Daniel Henrique Barboza wrote:

On 4/6/22 07:08, Bin Meng wrote:
On Tue, Apr 5, 2022 at 10:36 PM Guo Zhi <qtxuning1999@sjtu.edu.cn> wrote:

There are still some files in the QEMU PPC code base that use TABs for indentation instead of using  spaces.
The TABs should be replaced so that we have a consistent coding style.

If this patch is applied, issue:


can be closed.

Please add the following tag in the commit:

Resolves: https://gitlab.com/qemu-project/qemu/-/issues/374

This will make Gitlab automatically close the issue when the patch is accepted.

Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
  hw/core/uboot_image.h  | 185 ++++++++++++++++++++---------------------
  hw/ppc/ppc440_bamboo.c |   6 +-
  hw/ppc/spapr_rtas.c    |  18 ++--
  include/hw/ppc/ppc.h   |  10 +--
  4 files changed, 109 insertions(+), 110 deletions(-)

diff --git a/hw/core/uboot_image.h b/hw/core/uboot_image.h

uboot_image.h was taken from the U-Boot source, I believe it should be
kept as it is.

(CCing Thomas since het explictly listed hw/core/uboot_image.h in the bug)

I am not sure about keeping this file as is.

Seems like uboot_image.h has originally been taken from U-Boot's include/image.h file ... but the two files are completely out of sync nowadays, e.g. U-Boot switched to enums instead of #defines at one point in time. So I think it does not make much sense to keep the TABs in here, and I'd rather like to see them replaced with spaces indeed.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]