qemu-ppc
[Top][All Lists]
Advanced

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH v2] hw/ppc: change indentation to spaces from TABs


From: Guo Zhi
Subject: Re: [PATCH v2] hw/ppc: change indentation to spaces from TABs
Date: Wed, 13 Apr 2022 23:03:08 +0800 (CST)

Thanks for your help, I'll pay attention to the commit specification next time.

Guo

----- Original Message -----
From: "Daniel Henrique Barboza" <danielhb413@gmail.com>
To: "Guo Zhi" <qtxuning1999@sjtu.edu.cn>, "C├ędric Le Goater" <clg@kaod.org>, 
"David Gibson" <david@gibson.dropbear.id.au>, "Greg Kurz" <groug@kaod.org>
Cc: "qemu-ppc" <qemu-ppc@nongnu.org>, "qemu-devel@nongnu.org Developers" 
<qemu-devel@nongnu.org>
Sent: Wednesday, April 13, 2022 9:00:15 PM
Subject: Re: [PATCH v2] hw/ppc: change indentation to spaces from TABs

On 4/11/22 23:12, Guo Zhi wrote:
> Resolves: https://gitlab.com/qemu-project/qemu/-/issues/374
> 
> There are still some files in the QEMU PPC code base that use TABs for 
> indentation instead of using  spaces. The TABs should be replaced so that we 
> have a consistent coding style.
> 

I forgot to mention about the commit msg. Ideally we want the commit msg
to have shorter lines. If you use 'vim' you can do that by selecting
the commit msg and hitting 'G' and 'W' in non-insert mode.

I've amended it before queueing, so don't worry about it. I also moved the
'Resolves' tag to the end of the commit msg, which I also forgot to mention
about.

> Signed-off-by: Guo Zhi <qtxuning1999@sjtu.edu.cn>
> ---


Reviewed-by: Daniel Henrique Barboza <danielhb413@gmail.com>



>   hw/ppc/ppc440_bamboo.c |  6 +++---
>   hw/ppc/spapr_rtas.c    | 18 +++++++++---------
>   include/hw/ppc/ppc.h   | 10 +++++-----
>   3 files changed, 17 insertions(+), 17 deletions(-)
> 
> diff --git a/hw/ppc/ppc440_bamboo.c b/hw/ppc/ppc440_bamboo.c
> index 7fb620b9a0..5ec3a9a17f 100644
> --- a/hw/ppc/ppc440_bamboo.c
> +++ b/hw/ppc/ppc440_bamboo.c
> @@ -3,9 +3,9 @@
>    *
>    * Copyright 2007 IBM Corporation.
>    * Authors:
> - *   Jerone Young <jyoung5@us.ibm.com>
> - *   Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> - *   Hollis Blanchard <hollisb@us.ibm.com>
> + *  Jerone Young <jyoung5@us.ibm.com>
> + *  Christian Ehrhardt <ehrhardt@linux.vnet.ibm.com>
> + *  Hollis Blanchard <hollisb@us.ibm.com>
>    *
>    * This work is licensed under the GNU GPL license version 2 or later.
>    *
> diff --git a/hw/ppc/spapr_rtas.c b/hw/ppc/spapr_rtas.c
> index d7c04237fe..d58b65e88f 100644
> --- a/hw/ppc/spapr_rtas.c
> +++ b/hw/ppc/spapr_rtas.c
> @@ -474,16 +474,16 @@ static void rtas_ibm_nmi_interlock(PowerPCCPU *cpu,
>   
>       if (spapr->fwnmi_machine_check_interlock != cpu->vcpu_id) {
>           /*
> -      * The vCPU that hit the NMI should invoke "ibm,nmi-interlock"
> +         * The vCPU that hit the NMI should invoke "ibm,nmi-interlock"
>            * This should be PARAM_ERROR, but Linux calls "ibm,nmi-interlock"
> -      * for system reset interrupts, despite them not being interlocked.
> -      * PowerVM silently ignores this and returns success here. Returning
> -      * failure causes Linux to print the error "FWNMI: nmi-interlock
> -      * failed: -3", although no other apparent ill effects, this is a
> -      * regression for the user when enabling FWNMI. So for now, match
> -      * PowerVM. When most Linux clients are fixed, this could be
> -      * changed.
> -      */
> +         * for system reset interrupts, despite them not being interlocked.
> +         * PowerVM silently ignores this and returns success here. Returning
> +         * failure causes Linux to print the error "FWNMI: nmi-interlock
> +         * failed: -3", although no other apparent ill effects, this is a
> +         * regression for the user when enabling FWNMI. So for now, match
> +         * PowerVM. When most Linux clients are fixed, this could be
> +         * changed.
> +         */
>           rtas_st(rets, 0, RTAS_OUT_SUCCESS);
>           return;
>       }
> diff --git a/include/hw/ppc/ppc.h b/include/hw/ppc/ppc.h
> index 364f165b4b..02af03ada2 100644
> --- a/include/hw/ppc/ppc.h
> +++ b/include/hw/ppc/ppc.h
> @@ -99,11 +99,11 @@ enum {
>       ARCH_MAC99_U3,
>   };
>   
> -#define FW_CFG_PPC_WIDTH     (FW_CFG_ARCH_LOCAL + 0x00)
> -#define FW_CFG_PPC_HEIGHT    (FW_CFG_ARCH_LOCAL + 0x01)
> -#define FW_CFG_PPC_DEPTH     (FW_CFG_ARCH_LOCAL + 0x02)
> -#define FW_CFG_PPC_TBFREQ    (FW_CFG_ARCH_LOCAL + 0x03)
> -#define FW_CFG_PPC_CLOCKFREQ (FW_CFG_ARCH_LOCAL + 0x04)
> +#define FW_CFG_PPC_WIDTH        (FW_CFG_ARCH_LOCAL + 0x00)
> +#define FW_CFG_PPC_HEIGHT       (FW_CFG_ARCH_LOCAL + 0x01)
> +#define FW_CFG_PPC_DEPTH        (FW_CFG_ARCH_LOCAL + 0x02)
> +#define FW_CFG_PPC_TBFREQ       (FW_CFG_ARCH_LOCAL + 0x03)
> +#define FW_CFG_PPC_CLOCKFREQ    (FW_CFG_ARCH_LOCAL + 0x04)
>   #define FW_CFG_PPC_IS_KVM       (FW_CFG_ARCH_LOCAL + 0x05)
>   #define FW_CFG_PPC_KVM_HC       (FW_CFG_ARCH_LOCAL + 0x06)
>   #define FW_CFG_PPC_KVM_PID      (FW_CFG_ARCH_LOCAL + 0x07)



reply via email to

[Prev in Thread] Current Thread [Next in Thread]