[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [RFC PATCH v3 1/5] ppc64: Add semihosting support

From: Richard Henderson
Subject: Re: [RFC PATCH v3 1/5] ppc64: Add semihosting support
Date: Wed, 20 Apr 2022 11:18:43 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.8.0

On 4/20/22 10:54, Leandro Lupori wrote:
On 4/18/22 17:22, Cédric Le Goater wrote:

diff --git a/semihosting/arm-compat-semi.c b/semihosting/arm-compat-semi.c
index 7a51fd0737..e1279c316c 100644
--- a/semihosting/arm-compat-semi.c
+++ b/semihosting/arm-compat-semi.c
@@ -268,6 +268,31 @@ common_semi_sys_exit_extended(CPUState *cs, int nr)


+#ifdef TARGET_PPC64

This PPC ifdef in an ARM file seems wrong.

The rest looks OK.

IIUC, arm-compat-semi.c is not an ARM specific file, but it's used by targets that implement ARM-compatible semihosting. It's currently used by ARM and RISC-V and both use target ifdefs in small parts of this file.

It would be nice to split these out to target/arch/arm-compat-semi.h or 
something akin.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]