Re: [RFC PATCH 6/7] target/ppc: Implemented pmxvf*ger*

[Richard Henderson]

On 4/26/22 05:50, Lucas Mateus Castro(alqotel) wrote:
> +&MMIRR_XX3_NO_P xa xb xt xmsk ymsk

Don't create this...

> +@MMIRR_XX3_NO_P ...... .. .... .. . . ........ xmsk:4 .... \
> +                ...... ... .. ..... ..... ........ ... \
> +                &MMIRR_XX3_NO_P xb=%xx3_xb xt=%xx3_at

just set pmsk=1 here instead...

> +static bool do_ger_MMIRR_XX3_NO_PMSK(DisasContext *ctx, arg_MMIRR_XX3_NO_P *a,
> +                                     int op_flag, void (*helper)(TCGv_env,
> +                                     TCGv_i32, TCGv_i32, TCGv_i32,
> +                                     TCGv_i32, TCGv_i32))
> +{
> +    arg_MMIRR_XX3 x;
> +    x.xa = a->xa;
> +    x.xb = a->xb;
> +    x.xt = a->xt;
> +    x.pmsk = 0x1;
> +    x.ymsk = a->ymsk;
> +    x.xmsk = a->xmsk;
> +    return do_ger_MMIRR_XX3(ctx, &x, op_flag, helper);
> +}

so you can drop this.


r~