Re: [RFC PATCH v2 3/7] target/ppc: Implemented pmxvi*ger* instructions

[Richard Henderson]

On 5/6/22 07:18, Lucas Mateus Castro(alqotel) wrote:
>       return true;
> +
> +}
> +static bool do_ger_XX3(DisasContext *ctx, arg_XX3 *a,

Watch the whitespace.

> +{
> +    arg_MMIRR_XX3 m;
> +    m.xa = a->xa;
> +    m.xb = a->xb;
> +    m.xt = a->xt;
> +    m.pmsk = 0xFF;
> +    m.ymsk = 0xF;
> +    m.xmsk = 0xF;
> +    return do_ger_MMIRR_XX3(ctx, &m, helper);
>   }

Is XX3 going to be used for anything else?  Is it worthwhile to move these into the 
decoder as explicit assignments?

Either way,
Reviewed-by: Richard Henderson <richard.henderson@linaro.org>

r~