[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

[PATCH v2 0/5] cleanup error handling in kvmppc_read_int_cpu_dt()

From: Daniel Henrique Barboza
Subject: [PATCH v2 0/5] cleanup error handling in kvmppc_read_int_cpu_dt()
Date: Wed, 6 Jul 2022 16:31:35 -0300


In this second version the biggest change is that I decided to
error_fatal inside kvmppc_get_clockfreq().

After the discussions in v1 [1] it became clear that falling back to a
default value when 'clock-frequency' is missing is a bad idea. Not because
of the default value per se, but for the absence of this root node
property in the userspace.

This assumption works fine with pSeries, the most used KVM platform we
have today. If this change causes a legitimate regression (i.e. a valid
use case where clock-frequency is missing from the DT and it's ok) in
other KVM-capable ppc boards, we can amend it case by case.

[1] https://lists.gnu.org/archive/html/qemu-devel/2022-06/msg05751.html

Daniel Henrique Barboza (4):
  target/ppc/kvm.c: do not return -1 on uint64_t return
  target/ppc: add errp to kvmppc_read_int_cpu_dt()
  target/ppc: use g_autofree in kvmppc_read_int_cpu_dt()
  target/ppc: exit(1) on failure in kvmppc_get_clockfreq()

jianchunfu (1):
  target/ppc: Add error reporting when opening file fails

 target/ppc/kvm.c | 46 +++++++++++++++++++++++++++++++---------------
 1 file changed, 31 insertions(+), 15 deletions(-)


reply via email to

[Prev in Thread] Current Thread [Next in Thread]