[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile

From: Lucas Mateus Martins Araujo e Castro
Subject: Re: [PATCH 1/8] tests/docker: Fix alpine dockerfile
Date: Wed, 27 Jul 2022 14:23:01 -0300
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.11.0

On 27/07/2022 14:09, Daniel P. Berrangé wrote:

On Wed, Jul 27, 2022 at 01:36:25PM -0300, Lucas Mateus Castro(alqotel) wrote:
Currently the run script uses 'readlink -e' but the image only has the
busybox readlink, this commit add the coreutils package which
contains the readlink with the '-e' option.
Use of 'readlink' is discouraged in favour of 'realpath'. AFAICT, we
can just do that change and not need the '-e' flag anyway.
So a patch just changing
-BASE="$(dirname $(readlink -e $0))"
+BASE="$(dirname $(realpath $0))"

Ok, I'll send it with v2.

Signed-off-by: Lucas Mateus Castro(alqotel) <lucas.araujo@eldorado.org.br>
 tests/docker/dockerfiles/alpine.docker | 1 +
 1 file changed, 1 insertion(+)

diff --git a/tests/docker/dockerfiles/alpine.docker b/tests/docker/dockerfiles/alpine.docker
index 3f4c0f95cb..2943a99730 100644
--- a/tests/docker/dockerfiles/alpine.docker
+++ b/tests/docker/dockerfiles/alpine.docker
@@ -21,6 +21,7 @@ RUN apk update && \
         cdrkit \
         ceph-dev \
         clang \
+        coreutils \
         ctags \
         curl-dev \
         cyrus-sasl-dev \
This file contents is autogenerated, so editting it manually is
wrong and changes will be lost.

True, that was one of the reasons I had problems with patch 8 (it changes the dockerfiles directly) but forgot that it'd apply here as well.

Lucas Mateus M. Araujo e Castro
Instituto de Pesquisas ELDORADO
Departamento Computação Embarcada
Analista de Software Trainee
Aviso Legal - Disclaimer

reply via email to

[Prev in Thread] Current Thread [Next in Thread]