Re: [PATCH 03/12] target/ppc: Move V(ADD|SUB)CUW to decodetree and use gvec

[Richard Henderson]

On 9/23/22 21:47, Lucas Mateus Castro(alqotel) wrote:
> +static bool do_vx_vaddsubcuw(DisasContext *ctx, arg_VX *a, int add)
> +{
> +    static const TCGOpcode vecop_list[] = {
> +        INDEX_op_cmp_vec, 0
> +    };
> +
> +    static const GVecGen3 op[] = {
> +        {
> +            .fniv = gen_VSUBCUW,
> +            .fno = gen_helper_VSUBCUW,
> +            .opt_opc = vecop_list,
> +            .vece = MO_32
> +        },
> +        {
> +            .fniv = gen_VADDCUW,
> +            .fno = gen_helper_VADDCUW,
> +            .opt_opc = vecop_list,
> +            .vece = MO_32
> +        },

FWIW, you could implement the .fni4 hook and drop the helper, knowing that tcg won't 
choose to out-line 4x elements.


r~