[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

RE: [PATCH 02/10] target/hexagon: Declare hexagon_regnames[] in "cpu.h"

From: Taylor Simpson
Subject: RE: [PATCH 02/10] target/hexagon: Declare hexagon_regnames[] in "cpu.h"
Date: Fri, 16 Dec 2022 22:48:42 +0000

> -----Original Message-----
> From: Philippe Mathieu-Daudé <philmd@linaro.org>
> Sent: Friday, December 16, 2022 4:06 PM
> To: qemu-devel@nongnu.org
> Cc: Daniel Henrique Barboza <danielhb413@gmail.com>; David Gibson
> <david@gibson.dropbear.id.au>; Xiaojuan Yang
> <yangxiaojuan@loongson.cn>; Mark Cave-Ayland <mark.cave-
> ayland@ilande.co.uk>; Bin Meng <bin.meng@windriver.com>; Richard
> Henderson <richard.henderson@linaro.org>; Artyom Tarasenko
> <atar4qemu@gmail.com>; Cédric Le Goater <clg@kaod.org>; Song Gao
> <gaosong@loongson.cn>; Alistair Francis <alistair.francis@wdc.com>; qemu-
> ppc@nongnu.org; Laurent Vivier <laurent@vivier.eu>; Palmer Dabbelt
> <palmer@dabbelt.com>; Taylor Simpson <tsimpson@quicinc.com>; Greg
> Kurz <groug@kaod.org>; qemu-riscv@nongnu.org; Max Filippov
> <jcmvbkbc@gmail.com>; Philippe Mathieu-Daudé <philmd@linaro.org>
> Subject: [PATCH 02/10] target/hexagon: Declare hexagon_regnames[] in
> "cpu.h"
> The hexagon_regnames array has TOTAL_PER_THREAD_REGS elements.
> TOTAL_PER_THREAD_REGS is defined in "cpu.h". Instead of pulling "cpu.h" in
> "internal.h", move the hexagon_regnames[] declaration to "cpu.h".
> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> ---
>  target/hexagon/cpu.h      | 2 ++
>  target/hexagon/internal.h | 2 --
>  2 files changed, 2 insertions(+), 2 deletions(-)

Why is this needed?  internal.h doesn't directly include cpu.h.

If the goal is to reduce the number of places where internal.h is included, 
then there would be additional changes.

If the concern is the dependence on TOTAL_PER_THREAD_REGS in internal.h, just 
change it to
extern const char * const hexagon_regnames[];


reply via email to

[Prev in Thread] Current Thread [Next in Thread]