Re: [PATCH v3 1/4] target/arm: Restrict 'qapi-commands-machine.h' to system emulation

[Markus Armbruster]

Philippe Mathieu-Daudé <philmd@linaro.org> writes:

> Since commit a0e61807a3 ("qapi: Remove QMP events and commands from
> user-mode builds") we don't generate the "qapi-commands-machine.h"
> header in a user-emulation-only build.
>
> Move the QMP functions from helper.c (which is always compiled)
> to arm-qmp-cmds.c (which is only compiled when system-emulation
> is selected).

Might want to cover the rename.  Perhaps:

  Move the QMP functions from helper.c (which is always compiled)
  to monitor.c (which is only compiled when system-emulation
  is selected).  Rename monitor.c to arm-qmp-cmds.c.

> Signed-off-by: Philippe Mathieu-Daudé <philmd@linaro.org>
> Reviewed-by: Richard Henderson <richard.henderson@linaro.org>