[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]
Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank
From: |
Peter Maydell |
Subject: |
Re: [PATCH v9 2/7] hw/intc/i8259: Implement legacy LTIM Edge/Level Bank Select |
Date: |
Tue, 7 Mar 2023 13:38:28 +0000 |
On Tue, 7 Mar 2023 at 13:36, Daniel Henrique Barboza
<danielhb413@gmail.com> wrote:
> On 3/7/23 08:42, BALATON Zoltan wrote:
> > @@ -168,6 +186,10 @@ static const VMStateDescription vmstate_pic_common = {
> > VMSTATE_UINT8(single_mode, PICCommonState),
> > VMSTATE_UINT8(elcr, PICCommonState),
> > VMSTATE_END_OF_LIST()
> > + },
> > + .subsections = (const VMStateDescription*[]) {
>
> Checkpatch will nag about it claiming that we need spaces between '*'. The
> maintainer
> can fix it in-tree though.
checkpatch nags because it fails to correctly parse this piece
of C syntax and thinks the '*' is a multiplication operator;
we should just ignore it in this instance.
thanks
-- PMM
- [PATCH v9 0/7] Pegasos2 fixes and audio output support, BALATON Zoltan, 2023/03/07
- [PATCH v9 3/7] Revert "hw/isa/vt82c686: Remove intermediate IRQ forwarder", BALATON Zoltan, 2023/03/07
- [PATCH v9 6/7] hw/usb/vt82c686-uhci-pci: Use PCI IRQ routing, BALATON Zoltan, 2023/03/07
- [PATCH v9 4/7] hw/isa/vt82c686: Implement PCI IRQ routing, BALATON Zoltan, 2023/03/07
- [PATCH v9 5/7] hw/ppc/pegasos2: Fix PCI interrupt routing, BALATON Zoltan, 2023/03/07
- [PATCH v9 7/7] hw/audio/via-ac97: Basic implementation of audio playback, BALATON Zoltan, 2023/03/07
- Re: [PATCH v9 0/7] Pegasos2 fixes and audio output support, Philippe Mathieu-Daudé, 2023/03/07