[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument

From: Richard Henderson
Subject: Re: [PATCH 04/10] hw/intc/arm_gic: Rename 'first_cpu' argument
Date: Fri, 7 Apr 2023 21:24:05 -0700
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.0

On 4/7/23 21:23, Richard Henderson wrote:
On 4/5/23 09:04, Philippe Mathieu-Daudé wrote:
"hw/core/cpu.h" defines 'first_cpu' as QTAILQ_FIRST_RCU(&cpus).

arm_gic_common_reset_irq_state() calls its second argument
'first_cpu', producing a build failure when "hw/core/cpu.h"
is included:

   hw/intc/arm_gic_common.c:238:68: warning: omitting the parameter name in a function definition is a C2x extension [-Wc2x-extensions]
     static inline void arm_gic_common_reset_irq_state(GICState *s, int 
   include/hw/core/cpu.h:451:26: note: expanded from macro 'first_cpu'
     #define first_cpu        QTAILQ_FIRST_RCU(&cpus)

KISS, rename the function argument.

Signed-off-by: Philippe Mathieu-Daudé<philmd@linaro.org>
  hw/intc/arm_gic_common.c | 5 +++--
  1 file changed, 3 insertions(+), 2 deletions(-)

Wow, that's ugly.  But a reasonable work-around.

Reviewed-by: Richard Henderson <richard.henderson@linaro.org>


reply via email to

[Prev in Thread] Current Thread [Next in Thread]