[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw

From: Cédric Le Goater
Subject: Re: [PATCH for-8.0 v2] target/ppc: Fix temp usage in gen_op_arith_modw
Date: Sun, 9 Apr 2023 19:29:44 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.9.1

On 4/9/23 18:21, Richard Henderson wrote:
On 4/8/23 14:24, Cédric Le Goater wrote:
On 4/8/23 09:05, Richard Henderson wrote:
Fix a crash writing to 't3', which is now a constant.
Instead, write the result of the remu to 't1'.

Fixes: 7058ff5231a ("target/ppc: Avoid tcg_const_* in translate.c")
Reported-by: Nicholas Piggin <npiggin@gmail.com>
Reviewed-by: Anton Johansson <anjo@rev.ng>
Signed-off-by: Richard Henderson <richard.henderson@linaro.org>

Looks good:


I have a PR ready for this same branch. If you want to me send,
just tell.

Yes, please.  Also, the comment above needs s/t1/t0/.  :-P

sure :)

Are you taking care of :




I don't think we have tcg tests for the prefix or mma instructions
introduced in P10. That would be good to have.


reply via email to

[Prev in Thread] Current Thread [Next in Thread]