[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 06/13] hw/ide: Extract bmdma_init_ops()

From: Philippe Mathieu-Daudé
Subject: Re: [PATCH 06/13] hw/ide: Extract bmdma_init_ops()
Date: Sun, 23 Apr 2023 19:43:22 +0200
User-agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 22/4/23 17:07, Bernhard Beschow wrote:
There are three private copies of bmdma_setup_bar() with small adaptions.
Consolidate them into one public implementation.

While at it rename the function to bmdma_init_ops() to reflect that the memory
regions being initialized represent BMDMA operations. The actual mapping as a
PCI BAR is still performed separately in each device.

Note that the bmdma_bar attribute will be renamed in a separate commit.

Signed-off-by: Bernhard Beschow <shentey@gmail.com>
  include/hw/ide/pci.h |  1 +
  hw/ide/cmd646.c      | 20 +-------------------
  hw/ide/pci.c         | 16 ++++++++++++++++
  hw/ide/piix.c        | 19 +------------------
  hw/ide/via.c         | 19 +------------------
  5 files changed, 20 insertions(+), 55 deletions(-)


Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>

reply via email to

[Prev in Thread] Current Thread [Next in Thread]