[Top][All Lists]

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE

From: David Hildenbrand
Subject: Re: [PATCH 08/10] hw/i386/pc: Remove PC_MACHINE_DEVMEM_REGION_SIZE
Date: Tue, 30 May 2023 15:41:58 +0200
User-agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0

On 30.05.23 15:11, David Hildenbrand wrote:
On 30.05.23 15:07, Michael S. Tsirkin wrote:
On Tue, May 30, 2023 at 01:38:36PM +0200, David Hildenbrand wrote:
There are no remaining users in the tree, so let's remove it.

Cc: Paolo Bonzini <pbonzini@redhat.com>
Cc: Richard Henderson <richard.henderson@linaro.org>
Cc: Eduardo Habkost <eduardo@habkost.net>
Cc: "Michael S. Tsirkin" <mst@redhat.com>
Cc: Marcel Apfelbaum <marcel.apfelbaum@gmail.com>
Signed-off-by: David Hildenbrand <david@redhat.com>

This (with previous patches) means any user changing
device-memory-region-size machine property is now broken, right?

We only had a getter, no setter (for good reason).

How do we know there are no users?

We don't. A quick google search makes "device-memory-region-size" and
"qom-get" only pop up in BUG fixes for something that appears to be QEMU
developer driven.

I don't consider it any useful, but if we want to be careful, sure we
can leave it around.

Looking further, libvirt doesn't use it (and never used it).

I already renamed it in 2018 without anybody complaining:


So I'm quite confident that nobody will really miss this property.


David / dhildenb

reply via email to

[Prev in Thread] Current Thread [Next in Thread]