Re: [PATCH v3 29/37] vfio/iommufd: Bypass EEH if iommufd backend

[Cédric Le Goater]

On 10/26/23 12:30, Zhenzhong Duan wrote:
> IBM EEH is only supported by legacy backend currently, bypass it
> for IOMMUFD backend.
>
> Signed-off-by: Zhenzhong Duan <zhenzhong.duan@intel.com>
> ---
>   hw/ppc/spapr_pci_vfio.c | 4 ++--
>   1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/hw/ppc/spapr_pci_vfio.c b/hw/ppc/spapr_pci_vfio.c
> index d1d07bec46..a2518838a1 100644
> --- a/hw/ppc/spapr_pci_vfio.c
> +++ b/hw/ppc/spapr_pci_vfio.c
> @@ -93,10 +93,10 @@ static VFIOContainer *vfio_eeh_as_container(AddressSpace 
> *as)
>   
>       bcontainer = QLIST_FIRST(&space->containers);
>   
> -    if (QLIST_NEXT(bcontainer, next)) {
> +    if (QLIST_NEXT(bcontainer, next) || bcontainer->ops != &vfio_legacy_ops) {

It's curious that a test on the VFIOIOMMUOps is needed so deep in
the software stack, and spapr should have its own VFIOIOMMUOps, which
de facto doesn't support iommufd.

Thanks,

C.


>           /*
>            * We don't yet have logic to synchronize EEH state across
> -         * multiple containers
> +         * multiple containers, iommufd isn't supported too.
>            */
>           bcontainer = NULL;
>           goto out;